storage: free space for XVA import by destroying source VM first#471
Merged
Conversation
This was referenced Apr 13, 2026
stormi
reviewed
Apr 14, 2026
stormi
reviewed
Apr 14, 2026
|
|
||
| def xva_export_import(vm: VM, compression: XVACompression, temp_large_dir: str, defer: Defer): | ||
| def xva_export_import(host: Host, sr: SR, vm_ref: str, compression: XVACompression, temp_large_dir: str, defer: Defer): | ||
| vm = host.import_vm(vm_ref, sr.uuid, True) |
Member
There was a problem hiding this comment.
I don't think this works if vm_ref is a UUID. Would copying or cloning imported_vm instead be good enough for this test?
Member
Author
There was a problem hiding this comment.
Yes, it should be good enough. I've updated the implementation.
604cee5 to
8427358
Compare
263b859 to
81ce353
Compare
81ce353 to
d273947
Compare
stormi
reviewed
Apr 16, 2026
d273947 to
f244985
Compare
stormi
approved these changes
Apr 17, 2026
f244985 to
e3515aa
Compare
1f54a73 to
75e6d68
Compare
e3515aa to
3806fe9
Compare
0070121 to
0dabee2
Compare
3806fe9 to
150f448
Compare
0dabee2 to
e5fefdf
Compare
150f448 to
067a161
Compare
e5fefdf to
75addb1
Compare
352e955 to
9facd7c
Compare
75addb1 to
254b633
Compare
This was referenced Apr 24, 2026
9facd7c to
ce6bf19
Compare
254b633 to
848fda3
Compare
848fda3 to
eb57567
Compare
ce6bf19 to
b2f50eb
Compare
b2f50eb to
3ee475f
Compare
eb57567 to
a0a7ef1
Compare
Refactor xva_export_import to create the VM during the test and destroy it before importing the exported image, freeing space for thick-provisioned SRs. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
a0a7ef1 to
1f002f0
Compare
3ee475f to
7a8a2d7
Compare
Millefeuille42
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test wasn't working properly with tick provisioning: in that case
the space from the source VM may be required to be able to import the
image.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 19 PRs:
mastermaster